Fix bug #81474: Make ReflectionAttribute non-final #7545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgolemon @carusogabriel Thoughts on this? Context is allowing implementation of adaptor classes in BetterReflection. It seems a bit weird to make a class non-final in an 8.0.12 release, but I guess better late than never? |
| @@ -653,7 +653,7 @@ private function __clone(): void {} | |||
| private function __construct() {} | |||
| } | |||
|
|
|||
| final class ReflectionAttribute | |||
| class ReflectionAttribute | |||
There was a problem hiding this comment.
Are there any possible BCs doing this? If not, go ahead 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying backport of #7520 to 8.0.